Report dropped stats aggregates in health metrics#11231
Open
Report dropped stats aggregates in health metrics#11231
Conversation
amarziali
added
type: enhancement
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58bde96499
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amarziali
added
the
tag: ai generated
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063737
Total [baseline] (11.119 s) : 0, 11119171
Agent [candidate] (1.066 s) : 0, 1065618
Total [candidate] (11.094 s) : 0, 11094391
section appsec
Agent [baseline] (1.275 s) : 0, 1275301
Total [baseline] (11.097 s) : 0, 11096824
Agent [candidate] (1.27 s) : 0, 1269546
Total [candidate] (11.163 s) : 0, 11162933
section iast
Agent [baseline] (1.244 s) : 0, 1244153
Total [baseline] (11.344 s) : 0, 11343607
Agent [candidate] (1.247 s) : 0, 1246945
Total [candidate] (11.369 s) : 0, 11369074
section profiling
Agent [baseline] (1.189 s) : 0, 1189102
Total [baseline] (11.083 s) : 0, 11083469
Agent [candidate] (1.187 s) : 0, 1186725
Total [candidate] (11.114 s) : 0, 11114375
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.255 ms) : 0, 1255
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (635.402 ms) : 0, 635402
BytebuddyAgent [candidate] (636.01 ms) : 0, 636010
AgentMeter [baseline] (29.544 ms) : 0, 29544
AgentMeter [candidate] (29.424 ms) : 0, 29424
GlobalTracer [baseline] (249.477 ms) : 0, 249477
GlobalTracer [candidate] (249.373 ms) : 0, 249373
AppSec [baseline] (32.661 ms) : 0, 32661
AppSec [candidate] (32.772 ms) : 0, 32772
Debugger [baseline] (60.557 ms) : 0, 60557
Debugger [candidate] (60.375 ms) : 0, 60375
Remote Config [baseline] (618.976 µs) : 0, 619
Remote Config [candidate] (604.534 µs) : 0, 605
Telemetry [baseline] (8.383 ms) : 0, 8383
Telemetry [candidate] (8.314 ms) : 0, 8314
Flare Poller [baseline] (9.747 ms) : 0, 9747
Flare Poller [candidate] (11.369 ms) : 0, 11369
section appsec
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (680.938 ms) : 0, 680938
BytebuddyAgent [candidate] (678.121 ms) : 0, 678121
AgentMeter [baseline] (12.406 ms) : 0, 12406
AgentMeter [candidate] (12.225 ms) : 0, 12225
GlobalTracer [baseline] (251.429 ms) : 0, 251429
GlobalTracer [candidate] (249.427 ms) : 0, 249427
IAST [baseline] (24.706 ms) : 0, 24706
IAST [candidate] (24.709 ms) : 0, 24709
AppSec [baseline] (186.226 ms) : 0, 186226
AppSec [candidate] (185.348 ms) : 0, 185348
Debugger [baseline] (65.111 ms) : 0, 65111
Debugger [candidate] (64.723 ms) : 0, 64723
Remote Config [baseline] (580.645 µs) : 0, 581
Remote Config [candidate] (571.51 µs) : 0, 572
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.852 ms) : 0, 7852
Flare Poller [baseline] (7.93 ms) : 0, 7930
Flare Poller [candidate] (9.05 ms) : 0, 9050
section iast
crashtracking [baseline] (1.238 ms) : 0, 1238
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (822.796 ms) : 0, 822796
BytebuddyAgent [candidate] (824.266 ms) : 0, 824266
AgentMeter [baseline] (11.268 ms) : 0, 11268
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (237.86 ms) : 0, 237860
GlobalTracer [candidate] (238.179 ms) : 0, 238179
IAST [baseline] (27.433 ms) : 0, 27433
IAST [candidate] (26.845 ms) : 0, 26845
AppSec [baseline] (32.288 ms) : 0, 32288
AppSec [candidate] (33.354 ms) : 0, 33354
Debugger [baseline] (63.247 ms) : 0, 63247
Debugger [candidate] (63.577 ms) : 0, 63577
Remote Config [baseline] (523.542 µs) : 0, 524
Remote Config [candidate] (535.014 µs) : 0, 535
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (8.03 ms) : 0, 8030
Flare Poller [baseline] (3.453 ms) : 0, 3453
Flare Poller [candidate] (3.46 ms) : 0, 3460
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (694.082 ms) : 0, 694082
BytebuddyAgent [candidate] (692.499 ms) : 0, 692499
AgentMeter [baseline] (8.967 ms) : 0, 8967
AgentMeter [candidate] (8.944 ms) : 0, 8944
GlobalTracer [baseline] (208.328 ms) : 0, 208328
GlobalTracer [candidate] (207.891 ms) : 0, 207891
AppSec [baseline] (32.662 ms) : 0, 32662
AppSec [candidate] (32.857 ms) : 0, 32857
Debugger [baseline] (66.148 ms) : 0, 66148
Debugger [candidate] (65.645 ms) : 0, 65645
Remote Config [baseline] (580.916 µs) : 0, 581
Remote Config [candidate] (589.575 µs) : 0, 590
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.072 ms) : 0, 8072
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.522 ms) : 0, 3522
ProfilingAgent [baseline] (94.016 ms) : 0, 94016
ProfilingAgent [candidate] (94.085 ms) : 0, 94085
Profiling [baseline] (94.562 ms) : 0, 94562
Profiling [candidate] (94.645 ms) : 0, 94645
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065215
Total [baseline] (8.833 s) : 0, 8832595
Agent [candidate] (1.072 s) : 0, 1071694
Total [candidate] (8.882 s) : 0, 8881805
section iast
Agent [baseline] (1.246 s) : 0, 1245594
Total [baseline] (9.501 s) : 0, 9501393
Agent [candidate] (1.245 s) : 0, 1245180
Total [candidate] (9.547 s) : 0, 9547139
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (636.433 ms) : 0, 636433
BytebuddyAgent [candidate] (640.118 ms) : 0, 640118
AgentMeter [baseline] (29.339 ms) : 0, 29339
AgentMeter [candidate] (29.677 ms) : 0, 29677
GlobalTracer [baseline] (248.823 ms) : 0, 248823
GlobalTracer [candidate] (251.177 ms) : 0, 251177
AppSec [baseline] (32.934 ms) : 0, 32934
AppSec [candidate] (33.061 ms) : 0, 33061
Debugger [baseline] (59.937 ms) : 0, 59937
Debugger [candidate] (60.457 ms) : 0, 60457
Remote Config [baseline] (596.315 µs) : 0, 596
Remote Config [candidate] (617.48 µs) : 0, 617
Telemetry [baseline] (9.962 ms) : 0, 9962
Telemetry [candidate] (9.28 ms) : 0, 9280
Flare Poller [baseline] (9.93 ms) : 0, 9930
Flare Poller [candidate] (9.792 ms) : 0, 9792
section iast
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (824.801 ms) : 0, 824801
BytebuddyAgent [candidate] (823.686 ms) : 0, 823686
AgentMeter [baseline] (11.282 ms) : 0, 11282
AgentMeter [candidate] (11.284 ms) : 0, 11284
GlobalTracer [baseline] (238.126 ms) : 0, 238126
GlobalTracer [candidate] (238.54 ms) : 0, 238540
IAST [baseline] (25.924 ms) : 0, 25924
IAST [candidate] (26.633 ms) : 0, 26633
AppSec [baseline] (33.144 ms) : 0, 33144
AppSec [candidate] (33.327 ms) : 0, 33327
Debugger [baseline] (63.119 ms) : 0, 63119
Debugger [candidate] (62.543 ms) : 0, 62543
Remote Config [baseline] (531.16 µs) : 0, 531
Remote Config [candidate] (523.83 µs) : 0, 524
Telemetry [baseline] (7.898 ms) : 0, 7898
Telemetry [candidate] (7.913 ms) : 0, 7913
Flare Poller [baseline] (3.411 ms) : 0, 3411
Flare Poller [candidate] (3.358 ms) : 0, 3358
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (19.234 ms) : 19040, 19428
. : milestone, 19234,
appsec (18.675 ms) : 18484, 18867
. : milestone, 18675,
code_origins (18.05 ms) : 17870, 18230
. : milestone, 18050,
iast (18.948 ms) : 18758, 19138
. : milestone, 18948,
profiling (19.412 ms) : 19217, 19607
. : milestone, 19412,
tracing (17.718 ms) : 17542, 17893
. : milestone, 17718,
section candidate
no_agent (19.736 ms) : 19534, 19937
. : milestone, 19736,
appsec (18.651 ms) : 18463, 18839
. : milestone, 18651,
code_origins (18.577 ms) : 18392, 18761
. : milestone, 18577,
iast (18.527 ms) : 18343, 18710
. : milestone, 18527,
profiling (18.094 ms) : 17915, 18274
. : milestone, 18094,
tracing (17.856 ms) : 17682, 18030
. : milestone, 17856,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.242 ms) : 1231, 1253
. : milestone, 1242,
iast (3.457 ms) : 3406, 3508
. : milestone, 3457,
iast_FULL (5.981 ms) : 5921, 6041
. : milestone, 5981,
iast_GLOBAL (3.729 ms) : 3666, 3792
. : milestone, 3729,
profiling (2.249 ms) : 2228, 2271
. : milestone, 2249,
tracing (1.857 ms) : 1842, 1872
. : milestone, 1857,
section candidate
no_agent (1.254 ms) : 1242, 1266
. : milestone, 1254,
iast (3.197 ms) : 3157, 3236
. : milestone, 3197,
iast_FULL (5.957 ms) : 5897, 6017
. : milestone, 5957,
iast_GLOBAL (3.685 ms) : 3621, 3749
. : milestone, 3685,
profiling (2.392 ms) : 2368, 2415
. : milestone, 2392,
tracing (1.887 ms) : 1871, 1902
. : milestone, 1887,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (3.855 ms) : 3631, 4078
. : milestone, 3855,
iast (2.286 ms) : 2216, 2357
. : milestone, 2286,
iast_GLOBAL (2.338 ms) : 2266, 2409
. : milestone, 2338,
profiling (2.113 ms) : 2058, 2169
. : milestone, 2113,
tracing (2.087 ms) : 2033, 2141
. : milestone, 2087,
section candidate
no_agent (1.493 ms) : 1481, 1505
. : milestone, 1493,
appsec (3.866 ms) : 3643, 4088
. : milestone, 3866,
iast (2.284 ms) : 2213, 2355
. : milestone, 2284,
iast_GLOBAL (2.336 ms) : 2265, 2407
. : milestone, 2336,
profiling (2.11 ms) : 2055, 2166
. : milestone, 2110,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
appsec (14.627 s) : 14627000, 14627000
. : milestone, 14627000,
iast (18.335 s) : 18335000, 18335000
. : milestone, 18335000,
iast_GLOBAL (17.797 s) : 17797000, 17797000
. : milestone, 17797000,
profiling (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
tracing (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
section candidate
no_agent (15.32 s) : 15320000, 15320000
. : milestone, 15320000,
appsec (14.672 s) : 14672000, 14672000
. : milestone, 14672000,
iast (18.696 s) : 18696000, 18696000
. : milestone, 18696000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
. : milestone, 17924000,
profiling (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
tracing (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
|
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
ConflatingMetricsAggregator
bounds its aggregate cache tomaxAggregates` entries via an LRU eviction policy. When the limit is exceeded, the least-recently-used aggregate is silently discarded — its accumulated hit counts and durations are lost and never reported to the agent.This PR wires the existing
CommonKeyCleanereviction callback intoHealthMetrics, emitting a new StatsD counterstats.dropped_aggregates(taggedreason:lru_eviction) each time an aggregate is evicted.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.